Urscript interface (backport #721) #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a urscript interface node * Add urscript_interface to standard launchfile * Added documentation for urscript_interface * Add a notice about incorrect script code * Add test for urscript interface * Move tests to one single tests This should avoid that different tests run in parallel * Wait for IO controller before checking IOs * Write an initial textmessage when connecting the urscript_interface * Wait for controller_manager services longer * Make sure we have a clean robot state without any program running once we enter our test similar to how we did it on the robot_driver test * Remove unneeded Destructor definition (cherry picked from commit 7ee47bd)
fmauch
force-pushed
the
mergify/bp/humble/pr-721
branch
from
bea77b8 to
cac074d
Compare
fmauch
added
humble
fmauch
approved these changes
Jul 21, 2023
Contributor
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
LGTM, merge conflict in docs resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #721 done by Mergify.
Cherry-pick of 7ee47bd has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com